• 0 Posts
  • 10 Comments
Joined 2 years ago
cake
Cake day: June 16th, 2023

help-circle
  • NoXPhasma@lemmy.worldtoLinux@lemmy.mlvkd3d 1.13 Released
    link
    fedilink
    arrow-up
    3
    ·
    edit-2
    4 months ago

    The ultimate goal of the WIneHQ team is to have their own fully DX12 implementation. The reason why vkd3d-proton exists is that Valve didn’t want to wait for it to mature and AFAIK they did have differences in what should be included in vkd3d. Which is why they don’t work on the same project.






  • It’s not just random, it simply does not even work. Because they set this:

    +/*Preferred Core featue is supported*/
    +static bool prefcore = true;
    

    And later in the code they do the if condition wrong:

    +	if (prefcore)
    +		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
    +	else
    +		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
    

    if should look like this:

    +	if (prefcore)
    +		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
    +	else
    +		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
    

    There is probably even more wrong, looking at the code quality, but this at least makes the preferred core work.